Skip to content

fix: sdk-5218 correct ios release workflows - #61

Merged
dciccale merged 2 commits into
masterfrom
fix/sdk-5218-release-workflow-bugs
Jul 30, 2026
Merged

fix: sdk-5218 correct ios release workflows#61
dciccale merged 2 commits into
masterfrom
fix/sdk-5218-release-workflow-bugs

Conversation

@dciccale

Copy link
Copy Markdown
Contributor

Summary

  • preserve full Git history when calculating the next version and changelog
  • publish exactly one GitHub release from the existing v<version> tag
  • prevent non-v releases from triggering CocoaPods deployment
  • remove checkout and Node setup steps that became unused after replacing conventional-github-releaser

Root cause

The draft workflow performed a depth-1 fetch after a full checkout, truncating the commit range used by standard-version. The publish workflow then delegated release creation to conventional-github-releaser, which allowed the 2.2.2 flow to produce both v2.2.2 and an unprefixed 2.2.2 release/tag and trigger CocoaPods twice.

The replacement uses gh release create with --verify-tag, so it can only publish the canonical tag already created by the draft workflow. It also exits successfully when the release already exists, making workflow reruns idempotent.

Validation

  • actionlint v1.7.12 passes for all three changed workflows
  • full-history fixture (v1.0.0, then feat, then fix) produces 1.1.0 and includes both commits in the changelog
  • equivalent depth-1 fixture reproduces 1.0.1 and omits the feature commit
  • static checks confirm --depth=1 and conventional-github-releaser are absent and the CocoaPods v-tag guard is present

Production behavior should be confirmed on the next legitimate Facebook release; no test release should be created against CocoaPods.

Linear: SDK-5218
Parent rollout: SDK-5074

@dciccale
dciccale marked this pull request as ready for review July 29, 2026 18:08
@dciccale
dciccale requested a review from a team as a code owner July 29, 2026 18:08
@dciccale
dciccale merged commit 56b74f8 into master Jul 30, 2026
9 checks passed
@dciccale
dciccale deleted the fix/sdk-5218-release-workflow-bugs branch July 30, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants